Add rollup transform dependencies support #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are failing due to the `TODO`, can't get a filename until the file has a source but I need to know the filename when generating the source?
Gets tests running
The `bundle` param in `generateBundle` hook doesn't list the `transform`-added dependencies in the bundles so they never get output and the tests fail.
Need to investigate the whole "dependency is invalidated" flow because that seems wrong atm.
- Make `common` be "common.css" by default so css doesn't get lost. - Reworked bundle algorithms to do the work to count CSS file references and get them into the right bundles - Updated for new `transform` behavior when changing a dependency.
It didn't work though, still explodes in watch mode ALL THE TIME
tivac
force-pushed
the
transform-dependencies
branch
from
817d366
to
152b181
Compare
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
=========================================
Coverage ? 99.09%
=========================================
Files ? 31
Lines ? 777
Branches ? 119
=========================================
Hits ? 770
Misses ? 7
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/rollup/rollup/blob/master/CHANGELOG.md#0610
Also a bunch of various rollup output cleanup bits.